Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI in main branch by running cargo fmt #183

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Jun 28, 2023

What does this PR do?:

This PR uses rustup run nightly cargo fmt --all to reformat the code in the main branch and hopefully fix up the failed CI jobs which are complaining about formatting.

For reference:

Motivation:

Bring main back to green.

Additional Notes:

Having blocking steps in CI for running the formatter seems a bit too heavy-handed...

How to test the change?:

Validate that CI is back to green.

@ivoanjo ivoanjo requested a review from a team as a code owner June 28, 2023 10:13
**What does this PR do?**:

This PR uses `rustup run nightly cargo fmt --all` to reformat the
code in the main branch and hopefully fix up the failed CI jobs which
are complaining about formatting.

For reference:
* https://gitlab.ddbuild.io/DataDog/apm-reliability/libddprof-build/-/jobs/288056193
* https://gitlab.ddbuild.io/DataDog/apm-reliability/libddprof-build/-/jobs/288056194

**Motivation**:

Bring `main` back to green.

**Additional Notes**:

Having blocking steps in CI for running the formatter seems a bit
too heavy-handed...

**How to test the change?**:

Validate that CI is back to green.
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivoanjo ivoanjo merged commit 8b66fd7 into main Jun 28, 2023
@bantonsson bantonsson deleted the ivoanjo/fix-ci-main-branch branch March 7, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants